Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove unnecessary files from NPM package #558

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

JohnAlbin
Copy link
Collaborator

This pull request is for: (mark with an "x")

  • examples/*
  • modules/next
  • packages/next-drupal
  • starters/basic-starter
  • starters/graphql-starter
  • Other

GitHub Issue: #556

Describe your changes

The NPM package has the src/ and tests/ files included and they are just bloat when downloading the package from npmjs.org.

Fixes #556

@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-drupal ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2023 9:31am

robdecker
robdecker previously approved these changes Oct 17, 2023
Copy link
Member

@robdecker robdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JohnAlbin
Copy link
Collaborator Author

Sorry, @robdecker. I rebased this branch and it dismissed your review. Can you review again? There are no changes.

@JohnAlbin JohnAlbin changed the title chore: remove unnecessary files from NPM package build: remove unnecessary files from NPM package Oct 18, 2023
Copy link
Member

@robdecker robdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JohnAlbin JohnAlbin merged commit 99811da into main Oct 19, 2023
15 checks passed
@JohnAlbin JohnAlbin deleted the 556-slim-npm-package branch October 19, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary files from NPM package
2 participants